chore: add infrastructure to write JavaScript tests with jest#100
Merged
chore: add infrastructure to write JavaScript tests with jest#100
Conversation
Jest is configured to run ESM tests. This requires to patch bpmn-visualization as its package.json lacks of ESM support in the latest available version. It will support it out of the box in a future version (at which point we can remove the patch from the project). Writing tests in TypeScript will be possible at a later date.
tbouffard
added
the
chore
|
♻️ PR Preview 014db18 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
10 tasks
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Sep 4, 2023
[INFRA] Remove the patch of the bpmn-visualization package.json when version
0.39.0 is available
#97
Closed
tbouffard
added a commit
that referenced
this pull request
Sep 4, 2023
Versions of `bpmn-visualization` prior to 0.39.0 did not support ESM in Node.js projects. They required the package.json file of `bpmn-visualization` to be patched in order to run tests. `[email protected]` fixes this problem, so the patch can be removed. closes #97 relates to #100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jest is configured to run ESM tests.
This requires to patch bpmn-visualization as its package.json lacks of ESM support in the latest available version. It will support it out of the box in a future version (at which point we can remove the patch from the project).
Writing tests in TypeScript will be possible at a later date.
Notes
Covers #65
Based on work done in #95