Skip to content

chore(dev): build with Node 20#271

Merged
tbouffard merged 1 commit intomainfrom
chore/bump_node
Aug 5, 2024
Merged

chore(dev): build with Node 20#271
tbouffard merged 1 commit intomainfrom
chore/bump_node

Conversation

@tbouffard
Copy link
Member

@tbouffard tbouffard commented Aug 5, 2024

Some dev dependencies require Node 20.
Bumping to a newer Node version removes warnings when running npm install and will prevent future problems.

Notes

Past warnings when running npm install that are now fixed (taken from https://github.com/process-analytics/bv-experimental-add-ons/actions/runs/10180354853/job/28158049293#step:3:35)

/opt/hostedtoolcache/node/18.20.4/x64/bin/npm ci --prefer-offline --audit false --ignore-scripts
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '[email protected]',
npm warn EBADENGINE   required: { node: '20 || >=22' },
npm warn EBADENGINE   current: { node: 'v18.20.4', npm: '10.7.0' }
npm warn EBADENGINE }
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '[email protected]',
npm warn EBADENGINE   required: { node: '20 || >=22' },
npm warn EBADENGINE   current: { node: 'v18.20.4', npm: '10.7.0' }
npm warn EBADENGINE }
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '[email protected]',
npm warn EBADENGINE   required: { node: '20 || >=22' },
npm warn EBADENGINE   current: { node: 'v18.20.4', npm: '10.7.0' }
npm warn EBADENGINE }
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '[email protected]',
npm warn EBADENGINE   required: { node: '20 || >=22' },
npm warn EBADENGINE   current: { node: 'v18.20.4', npm: '10.7.0' }
npm warn EBADENGINE }
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '[email protected]',
npm warn EBADENGINE   required: { node: '20 || >=22' },
npm warn EBADENGINE   current: { node: 'v18.20.4', npm: '10.7.0' }
npm warn EBADENGINE }
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '[email protected]',
npm warn EBADENGINE   required: { node: '20 || >=22' },
npm warn EBADENGINE   current: { node: 'v18.20.4', npm: '10.7.0' }
npm warn EBADENGINE }

@tbouffard
chore(dev): build with Node 20
b0991b0 
Some dev dependencies require Node 20. Bumping to a newer Node version removes warnings when running
`npm install` and will prevent future problems.
@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Aug 5, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

♻️ PR Preview b0991b0 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@tbouffard tbouffard marked this pull request as ready for review August 5, 2024 14:45
@tbouffard tbouffard merged commit a827c80 into main Aug 5, 2024
@tbouffard tbouffard deleted the chore/bump_node branch August 5, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tbouffard