Skip to content

chore: move project to ESM#99

Merged
tbouffard merged 1 commit intomainfrom
chore/move_to_esm
Aug 31, 2023
Merged

chore: move project to ESM#99
tbouffard merged 1 commit intomainfrom
chore/move_to_esm

Conversation

@tbouffard
Copy link
Member

@tbouffard tbouffard commented Aug 31, 2023

Instruct Node.js to consider .js file as ESM module.
The package.json file now declares "exports". This can be useful when testing code using bv-addons in a Node.js environment.
It's also marked as having no side effects ("sideEffects": false) to enable tools like webpack to better manage tree shaking.

Configure tools to manage all specific JS/TS extension.

  • Migrate configuration files to ESM.
  • The eslint configuration file is still using CommonJS because v8.48.0 doesn't support ESM. Add typings to ease configuration change in IDE.

Notes

Based on work done during #95 and #96
See also process-analytics/bpmn-visualization-js#2840

Resources

Instruct Node.js to consider .js file as ESM module.
The `package.json` file now declares "exports". This can be useful when testing code using bv-addons
in a  Node.js environment.
It's also marked as having no side effects ("sideEffects": false) to enable tools like webpack to
better manage tree shaking.

Configure tools to manage all specific JS/TS extension.
Migrate configuration files to ESM.
The eslint configuration file is still using CommonJS because v8.48.0 doesn't support ESM. Add
typings to ease configuration change in IDE.
@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Aug 31, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Aug 31, 2023

♻️ PR Preview a989a9f has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@tbouffard tbouffard marked this pull request as ready for review August 31, 2023 04:11
@tbouffard tbouffard merged commit 9b496ac into main Aug 31, 2023
@tbouffard tbouffard deleted the chore/move_to_esm branch August 31, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant