Fix assignments to properties of inputs in branches in p5.strands#8397
Merged
davepagurek merged 2 commits intodev-2.0from Jan 10, 2026
Merged
Fix assignments to properties of inputs in branches in p5.strands#8397davepagurek merged 2 commits intodev-2.0from
inputs in branches in p5.strands#8397davepagurek merged 2 commits intodev-2.0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8396
Changes:
.copy()on any object modified in any way in a branch. If you assign tocolor.rgb, we want to docolor.copy(). That made sense because that's a sizzle assignment. But it broke if you assigned toinputs.color, it would doinputs.copy(), which doesn't work becauseinputsis a struct.colorincolor.rgb,inputs.colorininputs.color, andinputs.colorininputs.color.rgb.Live: https://editor.p5js.org/davepagurek/sketches/vOrLgKr0R
PR Checklist
npm run lintpasses