Fix noiseDetail() in p5.js 2.x so that the falloff parameter defaults to 0.5 when omitted.#8417
Conversation
|
🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors! Thank You! |
|
Thanks for taking this on! This looks good so far, although we also override p5.js/src/strands/strands_api.js Lines 168 to 175 in a491a9e |
|
Oh one other thing, you don't have to manually update parameterData.json, running |
|
Added default parameter handling to the noiseDetail override in strands_api.js as suggested. |
|
@all-contributors please add @shuklaaryan367-byte for code |
|
I've put up a pull request to add @shuklaaryan367-byte! 🎉 |
Resolves #8402
Changes:
falloffin runtime implementationScreenshots of the change:
Not applicable (non-visual change)
PR Checklist
npm run lintpasses