Fix #4638: make offscreen PGraphicsFX2D work.#4698
Fix #4638: make offscreen PGraphicsFX2D work.#4698GKFX wants to merge 2 commits intoprocessing:masterfrom
Conversation
|
BTW, you still can't use an off-screen PGraphicsFX2D in an AWT sketch because of the rule that graphics code must be limited to the FX Application Thread. My attempt to use |
|
What does “This was tested against OpenJFX rather than the default JavaFX since Processing was flatly refusing to compile otherwise” mean? |
|
I added a line to core/build.xml to put my system copy of openjfx on the classpath. Ant otherwise couldn't find the javafx package, even with a completely clean, unmodified repository. I'll try and get you a copy of the error message tomorrow, if it's still happening. (I'm sorry for that very vague statement; I posted it in a hurry!) |
|
The error is |
|
@JakubValtar Low priority, but perhaps you can review when you get a chance? |
|
Why isn't this in the current source? I added it as a separate implementation and it works perfectly. |
|
@Momopey -- Great that it worked for you. Can you share details about what you tested on? That might help core devs to review. |
|
Now merged into the standalone JavaFX library for 4.0 beta 4: processing/processing4-javafx@f7b8c29 JavaFX development is now taking place here: https://github.com/processing/processing4-javafx |
|
…and thanks @GKFX for the usable fix! Made one change to only set alpha when |
|
This pull request has been automatically locked. Pull requests that have been closed are automatically locked 30 days after the last comment. |
This was tested against OpenJFX rather than the default JavaFX since Processing was flatly refusing to compile otherwise; I assume it will work the same regardless.
Fix #4638.