Save and restore the dock's display state from persistent storage by alanpoon · Pull Request #422 · project-robius/robrix

alanpoon · 2025-03-05T13:19:47Z

Fixes #414

Screen.Recording.2025-03-12.at.1.21.32.PM.mov

Save the layout when the Desktop UI view is being hidden, e.g., due to a resize event. (Save the UI layout when transitioning from Desktop --> Mobile layout #251)
Preserve the proportional size of each pane in the dock.
If the user has resized a dock pane by dragging the splitter, that is currently not preserved.
When the user closes/exits the Robrix app, we should save the layout to the persistent settings on disk. Then, we can restore that saved layout automatically upon the next time the user re-opens Robrix.
This can also be offered as a preference/setting in the settings pane, once that is implement.
[] Future Save the layout on demand (a future feature), such that the user can store a list of "favorite" layouts that they can easily switch between, on demand.

I have also explored saving and restoring the window dimension. Currently makepad does not have a solution resize the window dynamically.

src/home/room_screen.rs

src/persistent_state.rs

src/app.rs

src/persistent_state.rs

src/home/room_screen.rs

Co-authored-by: Kevin Boos <[email protected]>

kevinaboos

a few nits about naming clarity:

The word "prompt" should be something like "notice" instead, since a prompt implies that we're asking the user to input some info. But really, we're just showing the user a notice that something is happening in the background.
Similarly, the word "timeout" should be replaced with "failure"/"failed"/"error", since timing out is just one potential error that could occur when loading a room.

See my other comments about how to potentially redesign the action handling logic for Pending, Success, and Timeout.

src/app.rs

src/sliding_sync.rs

src/persistent_state.rs

src/sliding_sync.rs

src/home/main_desktop_ui.rs

kevinaboos · 2025-06-20T20:51:59Z

Waiting for Makepad to merge in api requirement for persistent storage and restoration of window_state makepad/makepad#770

It's been merged now.

kevinaboos

Thanks for the Makepad contribution, this PR is nearly ready. I just left a few very minor comments.

Cargo.toml

src/utils.rs

src/app.rs

src/home/main_desktop_ui.rs

src/home/rooms_list.rs

src/persistent_state.rs

src/sliding_sync.rs

Co-authored-by: Kevin Boos <[email protected]>

kevinaboos

I've cleaned up this PR and the code is now ready to go, so please pull down the latest changes onto your computer.

Currently, there is still an issue with InviteScreens: they are not being drawn properly after they get restored. See the screenshot below:

This is because you need to add the same logic used in the RoomScreen to the InviteScreen too. Things like checking whether the room is_loaded, then calling set_displayed_invite() when it becomes loaded, etc. It also needs the same restore_status_label.

kevinaboos · 2025-06-24T19:41:33Z

I've also noticed that the window position is not always respected by macOS, but the window size is used properly. Nothing we can do there, as it seems to be an OS-enforced behavior.

alanpoon · 2025-06-25T07:37:15Z

I've cleaned up this PR and the code is now ready to go, so please pull down the latest changes onto your computer.

Currently, there is still an issue with InviteScreens: they are not being drawn properly after they get restored. See the screenshot below:
This is because you need to add the same logic used in the RoomScreen to the InviteScreen too. Things like checking whether the room is_loaded, then calling `set_displayed_invite()` when it becomes loaded, etc. It also needs the same `restore_status_label`.

Fixed.

kevinaboos · 2025-06-25T20:02:57Z

Friendly reminder to actually test your code before requesting a review. Looks like you forgot to clear the restore_status_label in the InviteScreen once it has been restored. It also needs to be outside of the inner view that holds the inviter_avatar and inviter_name, otherwise it causes alignment issues even when empty.

I've fixed it now.

There were also several unnecessary clone()s introduced, one of which was expensive (the InviteDetails). Try to avoid those wherever possible.

Dock save/restore improvement

9467b11

alanpoon self-assigned this Mar 5, 2025

alanpoon mentioned this pull request Mar 6, 2025

Persistent event cache for timeline event #419

Closed

alanpoon added 2 commits March 12, 2025 13:15

Added more comments

5944c27

Merge branch 'main' into save_ui_persistent#414

1f259e3

alanpoon commented Mar 12, 2025

View reviewed changes

src/home/room_screen.rs Outdated Show resolved Hide resolved

remove whitespace

3b5b3ae

alanpoon marked this pull request as ready for review March 12, 2025 05:28

alanpoon added the waiting-on-review This issue is waiting to be reviewed label Mar 12, 2025

kevinaboos requested changes Mar 12, 2025

View reviewed changes

src/persistent_state.rs Outdated Show resolved Hide resolved

src/app.rs Outdated Show resolved Hide resolved

src/persistent_state.rs Outdated Show resolved Hide resolved

src/persistent_state.rs Outdated Show resolved Hide resolved

src/home/room_screen.rs Outdated Show resolved Hide resolved

kevinaboos added waiting-on-author This issue is waiting on the original author for a response and removed waiting-on-review This issue is waiting to be reviewed labels Mar 12, 2025

alanpoon and others added 6 commits March 14, 2025 10:44

Prompt text for roomscreen pending

da9ef4c

remove unnecessary

29a2e9f

Update src/persistent_state.rs

6750fca

Co-authored-by: Kevin Boos <[email protected]>

fix format

d61863a

doc improvement

855aca3

Merge branch 'main' into save_ui_persistent#414

8dd1262

alanpoon added waiting-on-review This issue is waiting to be reviewed and removed waiting-on-author This issue is waiting on the original author for a response labels Mar 14, 2025

kevinaboos requested changes Mar 20, 2025

View reviewed changes

kevinaboos added waiting-on-author This issue is waiting on the original author for a response and removed waiting-on-review This issue is waiting to be reviewed labels Mar 20, 2025

alanpoon added 4 commits March 27, 2025 20:28

async_for read dock files

9acfdea

cleanup on save_ui

c99022e

minor cleanup

12a2e74

Merge branch 'main' into save_ui_persistent#414

1b8e6f2

alanpoon added waiting-on-review This issue is waiting to be reviewed and removed waiting-on-author This issue is waiting on the original author for a response labels Mar 27, 2025

remove extra lines

1a0d98b

alanpoon added 4 commits June 17, 2025 14:13

configure_window

44e1995

Merge branch 'main' into save_ui_persistent#414

23fd9ec

revert makepad version

2a670f9

improvement in persistent state

2012016

alanpoon added 3 commits June 23, 2025 14:58

Merge branch 'main' into save_ui_persistent#414

806d8ea

call MainDesktopUiAction::DockLoadToAppState directly

f34b1ab

remove Mousemove

6d212fc

kevinaboos requested changes Jun 23, 2025

View reviewed changes

alanpoon and others added 6 commits June 24, 2025 10:39

Save and restore dock state

8b0cc2c

Update src/home/main_desktop_ui.rs

65c8721

Co-authored-by: Kevin Boos <[email protected]>

change occurence to LoadDockFromAppState

14ea9c2

Update src/persistent_state.rs

c1a1a7e

Co-authored-by: Kevin Boos <[email protected]>

Update src/persistent_state.rs

717bd4a

Co-authored-by: Kevin Boos <[email protected]>

cleanup

d661013

kevinaboos requested changes Jun 24, 2025

View reviewed changes

kevinaboos and others added 4 commits June 24, 2025 12:42

Add logs, more code simplification

22efcac

clippy

12f3160

fix save ui for Invite screen

aecc405

remove println

8267525

Fix InviteScreen layout, remove unneeded clones.

0a937f8

kevinaboos previously approved these changes Jun 25, 2025

View reviewed changes

kevinaboos added 2 commits June 25, 2025 14:48

minor cleanup

1cad21b

fix background colors. Only draw the status label for non-loaded rooms.

b5c6260

kevinaboos approved these changes Jun 25, 2025

View reviewed changes

This was referenced Jul 17, 2025

Save last selected room_id #554

Closed

Change persistent state type from SavedDockState to AppState. #555

Merged

Conversation

alanpoon commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kevinaboos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kevinaboos commented Jun 20, 2025

Uh oh!

kevinaboos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kevinaboos left a comment

Choose a reason for hiding this comment

Uh oh!

kevinaboos commented Jun 24, 2025

Uh oh!

alanpoon commented Jun 25, 2025

Uh oh!

kevinaboos commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alanpoon commented Mar 5, 2025 •

edited

Loading

kevinaboos commented Jun 25, 2025 •

edited

Loading