Skip to content

Remove check job in Github Workflows#485

Merged
kevinaboos merged 2 commits intoproject-robius:mainfrom
emmettlu:fix484
May 20, 2025
Merged

Remove check job in Github Workflows#485
kevinaboos merged 2 commits intoproject-robius:mainfrom
emmettlu:fix484

Conversation

@emmettlu
Copy link
Contributor

@emmettlu emmettlu commented May 16, 2025 •
edited
Loading

Fix issue: #484

@emmettlu emmettlu changed the title Remove 'check' job in Github Actions Remove 'check' job in Github Workflows May 16, 2025
@emmettlu emmettlu changed the title Remove 'check' job in Github Workflows Remove check job in Github Workflows May 16, 2025
@kevinaboos
Copy link
Member

kevinaboos commented May 18, 2025

Agreed, this looks good to me.

I think we should have a separate CI pass that does an actual cargo build on all of the supported platforms, since cargo check or cargo clippy won't catch link-time errors that can only occur after a full build.

The matrix of host platforms and target platforms is in the README, copied here:

Host OS Target Platform Builds? Runs?
macOS macOS ✅ ✅
macOS Android ✅ ✅
macOS iOS ✅ ✅
Linux Linux ✅ ✅
Linux Android ✅ ✅
Windows Windows ✅ ✅
Windows Android ✅ ✅

@emmettlu
Copy link
Contributor Author

emmettlu commented May 19, 2025

I think we should have a separate CI pass that does an actual cargo build on all of the supported platforms, since cargo check or cargo clippy won't catch link-time errors that can only occur after a full build.

Agree.

@kevinaboos
Copy link
Member

kevinaboos commented May 19, 2025

This PR is currently marked as a draft. If it's ready, please mark it as ready for review so I can review & merge it in. Thanks!

@emmettlu
Copy link
Contributor Author

emmettlu commented May 19, 2025 •
edited
Loading

This PR is currently marked as a draft. If it's ready, please mark it as ready for review so I can review & merge it in. Thanks!

OK, Lets put the build job in the later pr. Thanks

@emmettlu emmettlu marked this pull request as ready for review May 19, 2025 09:09
kevinaboos
kevinaboos approved these changes May 20, 2025
View reviewed changes
Copy link
Member

@kevinaboos kevinaboos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Can you add the multi-target cargo build CI checks soon? Those would be quite valuable for all future PRs.

@kevinaboos
Copy link
Member

kevinaboos commented May 20, 2025

I've removed the "cargo clippy" action from the branch protection rules.

@kevinaboos kevinaboos merged commit 18b162a into project-robius:main May 20, 2025
2 checks passed
@kevinaboos kevinaboos mentioned this pull request May 20, 2025
Closed
@kevinaboos kevinaboos mentioned this pull request Jun 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinaboos kevinaboos kevinaboos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emmettlu @kevinaboos