update dependency to matrix 0.11#498
Merged
kevinaboos merged 18 commits intoproject-robius:mainfrom Jun 20, 2025
Merged
Conversation
Member
|
Oh great, thanks! I was just about to do this. @alanpoon Instead of tracking v0.11 from crates.io, can you track the latest |
emmettlu
reviewed
Jun 11, 2025
emmettlu
reviewed
Jun 11, 2025
emmettlu
reviewed
Jun 11, 2025
emmettlu
reviewed
Jun 11, 2025
emmettlu
reviewed
Jun 11, 2025
emmettlu
reviewed
Jun 11, 2025
emmettlu
reviewed
Jun 11, 2025
alanpoon
commented
Jun 13, 2025
kevinaboos
requested changes
Jun 13, 2025
Member
kevinaboos
left a comment
There was a problem hiding this comment.
Great job, thanks Alan! I left a few minor comments, but nothing too major.
I'm really happy to see that the matrix-sdk finally migrated to the concept of a "Message-like event", which is what I always wanted instead of the hacky MessageOrSticker enum that i introduced. See my comment about that below.
Co-authored-by: Kevin Boos <[email protected]>
kevinaboos
reviewed
Jun 19, 2025
kevinaboos
approved these changes
Jun 20, 2025
Member
kevinaboos
left a comment
There was a problem hiding this comment.
Thanks Alan, looks great now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.