Conversation
SuperQ
requested changes
Dec 5, 2024
Member
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
There is no need to revert this. This is a bug fix for the previous release where we did not correctly make timestamps UTC.
Member
Author
|
It's a feature, not a bug… :) But even if we come to the conclusion in the end that it is a bug fix, let's first come to that conclusion before we start cutting actual releases with the changed log format. |
SuperQ
approved these changes
Mar 31, 2025
Member
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
Approved at 2025-03-31 Dev Summit
Member
|
I guess we need to do a bit of a rebase revert. |
Member
Author
|
Yeah, other things happened with fine tuning the timestamp format. I'll push a new commit shortly. |
As per the dev-summit discussion, we want to use the default timezone as selected by slog after all rather than a hardcoded UTC. (This was accidentally introduced earlier when moving from gokit to slog, but then switched back to hardcoded UTC in PR #735.) Environments that have configured UTC anyway won't see any difference, but those with other timezones configured will see the configured timezone for the timestamps in their logs. This is in line with how slog behaves by default. Example timestamp _before_ this change and also _after_ this change with UTC configured in the environment via a suitable way (e.g. setting `TZ=UTC` on Linux): time=2025-04-10T12:00:38.179Z Example timestamp _after_ this change with location Europe/Berlin, i.e. timezone is CET or CEST: time=2025-04-10T14:00:03.120+02:00 Note that the precise delta to UTC is in the timestamp. So this change will also be transparent to the usual logs processing tools. Signed-off-by: beorn7 <[email protected]>
beorn7
changed the title
Member
Author
|
Here we are. @SuperQ PHAL. |
SuperQ
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 145b50a.
See discussion on Slack. We should first decide which log format we want before changing it from what is already released in prometheus/prometheus.
UPDATE:
This is the new commit description:
As per the dev-summit discussion, we want to use the default timezone
as selected by slog after all rather than a hardcoded UTC.
(This was accidentally introduced earlier when moving from gokit to
slog, but then switched back to hardcoded UTC in PR #735.)
Environments that have configured UTC anyway won't see any difference,
but those with other timezones configured will see the configured
timezone for the timestamps in their logs. This is in line with how
slog behaves by default.
Example timestamp before this change and also after this change
with UTC configured in the environment via a suitable way (e.g.
setting
TZ=UTCon Linux):Example timestamp after this change with location Europe/Berlin,
i.e. timezone is CET or CEST:
Note that the precise delta to UTC is in the timestamp. So this change
will also be transparent to the usual logs processing tools.