Conversation
Signed-off-by: Arve Knudsen <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables the usestdlibvars linter in the Go configuration and fixes all violations by replacing hardcoded HTTP method strings with the corresponding standard library constants.
- Enabled the
usestdlibvarslinter in the golangci-lint configuration - Replaced hardcoded "GET" strings with
http.MethodGetconstant across test files - Updated HTTP request creation calls to use standard library constants instead of string literals
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .golangci.yml | Uncommented the usestdlibvars linter to enable it |
| server/static_file_server_test.go | Replaced hardcoded "GET" with http.MethodGet in test request creation |
| route/route_test.go | Updated multiple test functions to use http.MethodGet instead of "GET" string |
| config/http_config_test.go | Replaced "GET" strings with http.MethodGet constant in HTTP request tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ywwg
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable usestdlibvars linter and fix issues.