Skip to content

Fix diff shades CI#4576

Merged
JelleZijlstra merged 1 commit intopsf:mainfrom
MeGaGiGaGon:fix-diff-shades-CI
Feb 7, 2025
Merged

Fix diff shades CI#4576
JelleZijlstra merged 1 commit intopsf:mainfrom
MeGaGiGaGon:fix-diff-shades-CI

Conversation

@MeGaGiGaGon
Copy link
Collaborator

Description

Looks like upload-artifact@v3 is now deprecated. Reading through the migration guide it looks like Black doesn't do any of the deprecated/changed behaviors, so this PR just bumps the number from 3 to 4.

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
    • Not user facing, no changelog needed
  • Add / update tests if necessary?
    • Not nessacary, changes are to CI
  • Add new / update outdated documentation?
    • Not nessacary, no behavior changed (hopefully)

@MeGaGiGaGon MeGaGiGaGon added the ci: skip news Pull requests that don't need a changelog entry. label Feb 6, 2025
@JelleZijlstra
Copy link
Collaborator

Thanks! There's something wrong with the wheel build; seems unrelated but if you have time to look into it, hopefully not too bad to fix.

@MeGaGiGaGon
Copy link
Collaborator Author

Looks like that did work to fix the diff_shades, but now the mypyc wheel build is failing. I think it might be spurious, or at least not my fualt, since the error is Cannot download, all mirrors were already tried without success from sh -c 'yum install -y clang gcc', and I don't see why updating the upload-artifact version would affect it.

@MeGaGiGaGon
Copy link
Collaborator Author

I tried looking at a previous run to see if it reports what url succeeded, but no dice. When I try to go to some of those URLs myself I also get 404s, so no clue what's happening, and extra not sure what to do since I'm on windows and very unfamiliar with anything linux.

@MeGaGiGaGon
Copy link
Collaborator Author

@JelleZijlstra can you retry the mypyc build? I manually checked all the links it lists for the mirrors, and two of them work for downloading the file, so I think it might succeed if it re-runs. The two working links:

@JelleZijlstra
Copy link
Collaborator

Thanks, retried!

@MeGaGiGaGon
Copy link
Collaborator Author

@JelleZijlstra it succeeded, so looks like it was just that one still working endpoint having a networking hiccup. I think this should be good for merge now that that's resolved.

@JelleZijlstra JelleZijlstra merged commit 5f23701 into psf:main Feb 7, 2025
46 of 47 checks passed
@MeGaGiGaGon MeGaGiGaGon deleted the fix-diff-shades-CI branch February 7, 2025 03:32
dsmith111 pushed a commit to jwstanly/black that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: skip news Pull requests that don't need a changelog entry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants