Conversation
|
Hi @fiorellabgs and thanks a lot for your contribution! We will review this and provide you some feedback ASAP. 👍 |
|
Amazing!!! |
|
Hi @ruphy - can I help getting this PR merged? @fiorellabgs and I would like to continue working on this together, possibly with @nclsppr, the merge would help a lot. Thanks! |
|
Hi,
Bien sûr! I will look into it tomorrow first thing in the morning.
Riccardo
…On Mon, Dec 2, 2019, 1:58 PM Bastien ***@***.***> wrote:
Hi @ruphy <https://github.com/ruphy> - can I help getting this PR merged?
@fiorellabgs <https://github.com/fiorellabgs> and I would like to
continue working on this together, possibly with @nclsppr
<https://github.com/nclsppr>, the merge would help a lot. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/italia/publiccode.yml/pull/74?email_source=notifications&email_token=AAAAP3V2IYQY2SYOPNTIIITQWUA6LA5CNFSM4JNCKXSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFTM4UQ#issuecomment-560385618>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAP3SCMY6M4R5QGCZLMYTQWUA6LANCNFSM4JNCKXSA>
.
|
|
The first version is in! Thanks a lot! 🎉 I merged this instead of #73 as it looked to me like more complete and you mentioned you are working with @nclsppr. Can you coordinate so I can close #73 ? I will now set aside some hours to work on the translation infrastructure, the more the project develops, the more I fear the translations will diverge. See for example this issue: italia/publiccode-editor#92 |
To be clear, we didn't plan to coordinate with @nclsppr but I'll work on this. More precisely, I'll review #73 and see if it is mergeable or if I can help rework it.
Yes, i18n is always a challenge - let us know if we can help! |
French Translation
Content
A contribution to help to translate the documentation in French, started here : https://github.com/italia/publiccode.yml/pull/73. I'm focusing on schema.core.rst.
As it is, the document is partially translated.
Review