Allow kind annotations in forall contexts#3576
Merged
natefaubion merged 15 commits intopurescript:masterfrom Apr 18, 2019
Merged
Allow kind annotations in forall contexts#3576natefaubion merged 15 commits intopurescript:masterfrom
forall contexts#3576natefaubion merged 15 commits intopurescript:masterfrom
Conversation
added 8 commits
March 24, 2019 19:24
…d information through type/kind checking
colinwahl
commented
Mar 26, 2019
Contributor
Author
|
I've got some tests I need to take a look at - I will get to that tomorrow. |
Contributor
Author
|
I've added some simple tests, but if anyone can think of some others, I would be glad to add them. |
natefaubion
reviewed
Apr 2, 2019
Contributor
Author
|
This should be ready for another look now :) |
natefaubion
approved these changes
Apr 9, 2019
hdgarrood
approved these changes
Apr 15, 2019
Contributor
Author
|
Let me know if there's anything else I need to do to get this merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for kind annotations in
forallcontexts. The parser changes aren't very important (hopefully they will go away soon in favor of purescript-cst :) ), but this change will allow us to plug in purescript-cst easier (see https://github.com/natefaubion/purescript-cst/blob/master/src/Language/PureScript/CST/Convert.hs#L173)This intends to close #3549