Warn against exported types with hidden constructors but Generic or Newtype instances#3907
Merged
hdgarrood merged 2 commits intopurescript:masterfrom Oct 11, 2020
Merged
Conversation
kl0tl
commented
Jul 6, 2020
Comment on lines
+737
to
+738
| [ DataNewtype.Newtype | ||
| , DataGenericRep.Generic |
Member
Author
There was a problem hiding this comment.
I introduced Language.PureScript.Constants.Data.Generic.Rep and Language.PureScript.Constants.Data.Newtype in order to not duplicate the names of those classes here and during type classes instances deriving but perhaps it would be ok to repeat them?
Member
Author
|
This warning is triggered by a few types in the following package set: https://raw.githubusercontent.com/JordanMartinez/package-sets/fix-warnings-ps-master-compatible/src/packages.dhall sha256:91ea6c8da90935f06b06b60ef6532bfc9f2c1233ec46500d1aab2b27d0dd2b49
I can open the necessary pull requests if and when we’ll want to move forward with this. |
kl0tl
force-pushed
the
public-hidden-constructors-warning
branch
from
84592d7 to
342abc7
Compare
kl0tl
force-pushed
the
public-hidden-constructors-warning
branch
from
342abc7 to
6b89a20
Compare
This was referenced Sep 9, 2020
Merged
hdgarrood
approved these changes
Oct 10, 2020
This was referenced Nov 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #3707.