Skip to content

remove old pull request template#49

Merged
garyb merged 2 commits intopurescript-web:masterfrom
growthagent:remove-pr-template-2
Jan 14, 2021
Merged

remove old pull request template#49
garyb merged 2 commits intopurescript-web:masterfrom
growthagent:remove-pr-template-2

Conversation

@toastal
Copy link
Contributor

@toastal toastal commented Jan 14, 2021

Description of the change

This caused an issue with case-insensitive filesystems

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@hdgarrood
Copy link
Contributor

hdgarrood commented Jan 14, 2021

Can we fold this content into the new one please?

@toastal
Copy link
Contributor Author

toastal commented Jan 14, 2021

You tell me? I suppose so.

@toastal
Copy link
Contributor Author

toastal commented Jan 14, 2021

@hdgarrood But I did add that section back for Prequisites

@garyb
Copy link
Member

garyb commented Jan 14, 2021

Thanks! That old template was added explicitly because I had to make the point repeatedly about adhering to the spec rather than MDN... I guess I need to check all the other -web repos now as they probably all have similar conflicting templates.

@garyb garyb merged commit de45735 into purescript-web:master Jan 14, 2021
@thomashoneyman
Copy link
Contributor

thomashoneyman commented Jan 14, 2021

Ugh, sorry about this. I can make that update for you, @garyb.

@garyb
Copy link
Member

garyb commented Jan 14, 2021

No problem! I didn't think to mention it when I saw the PRs going up. If you have a script or something that makes it easy, go ahead, otherwise I don't mind doing it 🙂.

@thomashoneyman
Copy link
Contributor

thomashoneyman commented Jan 14, 2021

I don’t, but I have a lunch break 😅 if they haven’t been done by then (about 4 hours from now) I can jump on it. Thanks!

@garyb
Copy link
Member

garyb commented Jan 14, 2021

Uh, actually, I'm having trouble with it exactly because of case-insensitive filesystem reasons, so if you do have time to do it, that would be great! 😄

@JordanMartinez JordanMartinez mentioned this pull request Jan 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@toastal @hdgarrood @garyb @thomashoneyman