Add navigator.languages#59
Merged
thomashoneyman merged 2 commits intopurescript-web:masterfrom Jul 19, 2021
Merged
Conversation
JordanMartinez
approved these changes
Jul 16, 2021
Contributor
JordanMartinez
left a comment
JordanMartinez
left a comment
There was a problem hiding this comment.
Thanks! Not sure if we need to say anything about the 94% not being 100%, but perhaps that should be left to the developer to check themselves as that number can easily change over time. Besides this is FFI, so they likely should be checking.
thomashoneyman
approved these changes
Jul 16, 2021
Member
I'd agree with that, these libraries are just meant to implement the standards even if unfortunately they're not entirely supported. |
toastal
force-pushed
the
navigator-languages
branch
from
832e415 to
9fc6a41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
purescript-webprojects. Although MDN is a great resource, it is not a suitable reference for this project.Found it: https://html.spec.whatwg.org/multipage/system-state.html#language-preferences
It appears all of the
Navigatorneeds to be updated on MDN.Description of the change
Languages, plural, gives the developer a list of languages the use prefers be the fallback. Personally I'd rather fallback from
en-UStoen-CAinstead ofen-GBand would take Spanish before French and this feature lets users tell the application their preferences (sadly at the cost of browser fingerprinting). This list is also the same list for theAccept-LanguageHTTP header the client sends to the server, but maybe a SPA would want to know as well since it will talk to the server a lot less.Checklist: