Merged
Conversation
pete-murphy
force-pushed
the
pm/68/fix-unnamed-instances
branch
from
198554c to
cdabe76
Compare
pete-murphy
commented
Feb 9, 2022
Comment on lines
11
to
+12
| Bugfixes: | ||
| - Added missing type class instance names for `DataTransferItemKind` (#69 by @ptrfrncsmrph) |
Contributor
Author
There was a problem hiding this comment.
Seemed like Bugfixes was the most appropriate category, let me know if I should move it somewhere else
pete-murphy
commented
Feb 9, 2022
Comment on lines
+21
to
+24
| derive instance eqDataTransferItemKind :: Eq DataTransferItemKind | ||
| derive instance ordDataTransferItemKind :: Ord DataTransferItemKind | ||
|
|
||
| instance Show DataTransferItemKind where | ||
| instance showDataTransferItemKind :: Show DataTransferItemKind where |
Contributor
Author
There was a problem hiding this comment.
Tested this locally by:
- installing PureScript
npm i [email protected]& Spagonpm i spago - confirming
npx run spago buildfailed - adding these changes
- confirming
npx run spago buildsucceeded
thomashoneyman
approved these changes
Feb 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
purescript-webprojects. Although MDN is a great resource, it is not a suitable reference for this project.Description of the change
Fixes #68. Adds missing type class instance names for
DataTransferItemKind.Checklist: