fix: using __cpp_nontype_template_args instead of __cpp_nontype_template_parameter_class#5330
Merged
henryiii merged 3 commits intopybind:masterfrom Aug 26, 2024
Merged
Conversation
rwgk
approved these changes
Aug 23, 2024
Collaborator
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
Thanks! (The situation with the two macros is really confusing!)
Collaborator
|
@henryiii for awareness. |
henryiii
pushed a commit
that referenced
this pull request
Sep 13, 2024
…mplate_parameter_class` (#5330) * fix: use `__cpp_nontype_template_args` instead of gnu extensions * fix: add feature test value * fix: change `PYBIND11_TYPING_H_HAS_STRING_LITERAL` skip reason
henryiii
pushed a commit
that referenced
this pull request
Sep 13, 2024
…mplate_parameter_class` (#5330) * fix: use `__cpp_nontype_template_args` instead of gnu extensions * fix: add feature test value * fix: change `PYBIND11_TYPING_H_HAS_STRING_LITERAL` skip reason
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since macro
__cpp_nontype_template_parameter_classis an GNU extension which has never been mentioned at cppreference, This PR use the standard__cpp_nontype_template_argsinstead to enable all compilers (currently MSVC) to usepy::typing::StringLiteral. By the way, this macro does't satisfy the feature-testing value at gcc-10 so it can provide a more standardized fix to #5201.Suggested changelog entry: