Skip to content

feat: add --extension-suffix to pybind11-config#5360

Merged
henryiii merged 2 commits intopybind:masterfrom
nikulpatel3141:nikulpatel3141/docs_python_extension_bug
Jan 24, 2025
Merged

feat: add --extension-suffix to pybind11-config#5360
henryiii merged 2 commits intopybind:masterfrom
nikulpatel3141:nikulpatel3141/docs_python_extension_bug

Conversation

@nikulpatel3141
Copy link
Contributor

@nikulpatel3141 nikulpatel3141 commented Sep 8, 2024 •
edited by henryiii
Loading

Description

The build command in the docs fails when using a python venv with a different version to the global installation as python3-config will use the global one.

For example on a machine with global python 3.12 in a venv using python 3.11:

(venv) $ python3-config --extension-suffix  # .cpython-311-x86_64-linux-gnu.so

(venv) $ python3 -c 'import sysconfig; print(sysconfig.get_config_var("EXT_SUFFIX"))'  # .cpython-312-x86_64-linux-gnu.so

This silently causes a 'ModuleNotFound' error as the venv cannot import the generated pybind module.

Suggested changelog entry:

Support ``--extension-suffix`` on the pybind11 command

rwgk
rwgk approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Is this needed because venv does not cover the python3-config command?

... after looking for 5 minutes ...

pypa/virtualenv#169

Apparently that's still an issue.

Waiting for a day or so for feedback from @henryiii

@henryiii
Copy link
Collaborator

henryiii commented Sep 27, 2024

I wonder if we should just bite the bullet and provide a --extension-suffix flag on pybind11-config?

@rwgk
Copy link
Collaborator

rwgk commented Sep 27, 2024

I wonder if we should just bite the bullet and provide a --extension-suffix flag on pybind11-config?

Sounds good to me.

@henryiii
feat: add --extension-suffix
8ccca8d 
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii self-requested a review as a code owner September 27, 2024 21:15
@henryiii henryiii merged commit c19c291 into pybind:master Jan 24, 2025
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jan 24, 2025
@henryiii henryiii changed the title fix docs build command on different global and venv python versions docs: fix build command on different global and venv python versions Mar 31, 2025
@henryiii henryiii changed the title docs: fix build command on different global and venv python versions feat: add --extension-suffix to pybind11-config Mar 31, 2025
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Apr 1, 2025
@BrewTestBot BrewTestBot mentioned this pull request Jul 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwgk rwgk rwgk approved these changes

@henryiii henryiii Awaiting requested review from henryiii henryiii is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nikulpatel3141 @henryiii @rwgk