Merged
Conversation
cyyever
force-pushed
the
libcpp_exception
branch
3 times, most recently
from
7e27da3 to
e92dd74
Compare
cyyever
force-pushed
the
libcpp_exception
branch
5 times, most recently
from
8e3fa6e to
549c343
Compare
Collaborator
|
This seems to fix an I'm too rushed to look carefully, but that looks good? Did you mean to (also) remove |
Contributor
Author
|
@rwgk I have no emscripten env, but I tested on Apple Silicon and it worked. Therefore I removed the MacOS+CPython case. |
Collaborator
We have the Could you please remove |
cyyever
force-pushed
the
libcpp_exception
branch
from
19d43f4 to
b3c2fb5
Compare
Contributor
Author
|
@rwgk Removed |
rwgk
reviewed
Oct 10, 2024
cyyever
force-pushed
the
libcpp_exception
branch
from
b95db5d to
101a786
Compare
rwgk
approved these changes
Oct 10, 2024
Collaborator
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
Thanks a lot for discovering and fixing this bug!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before this PR, exception translation was still failing on libc++. The failure reason is the visibility of exceptions, which was already discovered in #2999 and reverted by #4324. This PR fixes it by detecting libc++ using the _LIBCPP_EXCEPTION macro and setting PYBIND11_EXPORT_EXCEPTION accordingly. The macro definition is moved below other C++ header inclusion to make sure that _LIBCPP_EXCEPTION is defined.
Suggested changelog entry:
``pybind11::builtin_exception`` is now explicitly exported when linked to libc++.