feat(types): updated py::capsule type hint to use new types.CapsuleType#5567
Merged
rwgk merged 1 commit intopybind:masterfrom Mar 18, 2025
Merged
feat(types): updated py::capsule type hint to use new types.CapsuleType#5567rwgk merged 1 commit intopybind:masterfrom
rwgk merged 1 commit intopybind:masterfrom
Conversation
henryiii
approved these changes
Mar 18, 2025
Collaborator
henryiii
left a comment
henryiii
left a comment
There was a problem hiding this comment.
Fine for now. If we add the fallback someday we should also add it for typing.Annotated.
henryiii
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Python 3.13 adds types.CapsuleType.
This PR changes the type hint for
py::capsuleto the new type.One open question:
Should I only enable
types.CapsuleTypefor Python Version>=3.13 or for all versions?Since this only changes type hints/signature it is only in strings and no import is required, so tests still work.
typing.Annotatedis already in use without version guard and requires Python Version >= 3.9.Nanobind falls back to
typing_extensions.CapsuleTypein previous versions.Suggested changelog entry: