fix(cmake): regression in include guard#5691
Merged
henryiii merged 1 commit intopybind:masterfrom May 26, 2025
Merged
Conversation
Signed-off-by: Henry Schreiner <[email protected]>
3 tasks
rwgk
changed the title
Contributor
|
I can confirm that this fixes the issue that I found! |
henryiii
commented
May 26, 2025
| include_guard(GLOBAL) | ||
| set(optional_global GLOBAL) | ||
| else() | ||
| include_guard(DIRECTORY) |
Collaborator
Author
There was a problem hiding this comment.
FWIW, I think this would have been safe to put DIRECTORY here, since there's already a GLOBAL on the main CMakeLists.txt. But this is safer for now, especially in RC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Proposed fix for #5686.
Suggested changelog entry:
include_guardaddition.