tests: always disable on the nogil build#5701
Merged
henryiii merged 4 commits intopybind:masterfrom May 29, 2025
Merged
Conversation
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/chore/moreft
branch
from
cee4851 to
12e8dff
Compare
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/chore/moreft
branch
from
3729032 to
4ed8395
Compare
rwgk
approved these changes
May 28, 2025
Collaborator
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
It might be helpful in the future to explain in a sentence or two why we're making the change in test_gil_scoped.py (info currently only under PR 5701, not easy to find).
Signed-off-by: Henry Schreiner <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #5700, this isn't actually skipping. Let's just always disable it on the free-threaded build.
Also a small docs fix mentioned in #5696.