docs: fix py::trampoline_self_life_support visibility in docs#5766
Merged
rwgk merged 1 commit intopybind:masterfrom Jul 24, 2025
Merged
docs: fix py::trampoline_self_life_support visibility in docs#5766rwgk merged 1 commit intopybind:masterfrom
rwgk merged 1 commit intopybind:masterfrom
Conversation
C++ classes default inheritance rule is private. I believe py::trampoline_self_life_support must be public to work correctly.
rwgk
approved these changes
Jul 24, 2025
Collaborator
rwgk
left a comment
There was a problem hiding this comment.
Thanks for catching these!
Collaborator
|
@b-pass this flake looks a little worrying: https://github.com/pybind/pybind11/actions/runs/16496837953/job/46644528777?pr=5766 Copy-pasting from the CI log, for future reference: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The documentation examples for
py::trampoline_self_life_supportinherit it privately which I belive is incorrect.Suggested changelog entry:
py::trampoline_self_life_supportvisibility in docs📚 Documentation preview 📚: https://pybind11--5766.org.readthedocs.build/