Merged
Conversation
Contributor
|
There is an error in CI: |
jeanas
requested changes
May 11, 2023
Contributor
|
@mazza-av I've added some commits to simplify your lexer, eliminating redundant states. Let me know if that looks good. If so I'll merge it. |
Contributor
Author
|
@jeanas the changes look good to me. I've added a docstring to the lexer that was missing. |
Contributor
|
Thank you! |
Collaborator
|
I try to make a release once a quarter. So sometime late July/early August for this feature, as new lexers etc. go into a new minor release (whereas we make point releases as needed.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to replace #2088 and closes #1634.
I have attempted to address the comments left by @jeanas.
tox -e checkandtox -e testTextwithWhitespace