Conversation
|
Fixed linter complaints, at least locally :-). |
jeanas
left a comment
There was a problem hiding this comment.
Generally looks OK, here are some more or less minor comments to address though.
Co-authored-by: Jean Abou-Samra <[email protected]>
Thanks for the review, good catches. Yes, some of pieces embarrassingly look non logical or even weird. I will resolve the things. |
|
Ping? |
Sorry for the delay, things went a bit unplanned last week. It is in my list. I am going to resolve all the comments today or tomorrow. |
|
I have updated the things. |
No worries; I was just trying to make sure of the status (we have a number of open PRs where I am not sure whether the author consciously abandoned them or just forgot about them…). I'll review this again. |
Co-authored-by: Jean Abou-Samra <[email protected]>
|
Thanks for the review. |
jeanas
left a comment
There was a problem hiding this comment.
Good! Just waiting for CI to complete.
Add OpenSCAD lexer
Ref. #886