Merged
Conversation
jeanas
requested changes
Jun 24, 2023
Contributor
|
Please also add some tests for the new functionality. |
Contributor
Author
|
Thanks for your suggestions. They were very helpful. I think the overall result is much improved. I am done with my changes and I believe the pull request is now read to go. |
jeanas
requested changes
Jun 26, 2023
Contributor
jeanas
left a comment
jeanas
left a comment
There was a problem hiding this comment.
Looks better, thanks. Still a few things to fix though.
Contributor
Author
|
I believe all the issues are now resolved. |
jeanas
approved these changes
Jun 26, 2023
Contributor
|
Thank you! |
Contributor
Author
|
Thank you very much. I appreciate all of your help and patience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change update pygments support for NestedText from version 1.0 to version 3.0.