Bugfix: Restore native in __init__.py#2484
Merged
jeanas merged 2 commits intopygments:masterfrom Aug 6, 2023
Merged
Conversation
Contributor
|
Thank you. @Anteru Are you available for a hotfix release? |
Collaborator
|
Yeah, I was just about to do one :( Just double-checking we didn't throw away more styles in that PR. |
Collaborator
|
Turns out the style map wasn't even sorted properly ... what a mess 😢 |
Collaborator
|
Shipped as 2.16.1. Sorry for the inconvenience -- looks like we need some better test strategy for the style map, given people can edit this manually and it should be possible to iterate over all files in |
Contributor
|
Yeah, we can probably do the same for styles as we're doing with |
Collaborator
|
We can and we should :) |
Contributor
Author
|
Thanks y'all, really appreciate such a quick response and on a weekend no less. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over at https://github.com/napari/napari
We're getting test failures due to a validation error:
napari/napari#6121
Investigating, I noticed that in PR #2443
nativewas dropped from the list. I assume it was not intentional, because the style itself does not appear to have been removed:https://github.com/pygments/pygments/blob/master/pygments/styles/native.py
So in this PR I re-add
'native': 'native::NativeStyle',to the list in the proper alphabetical spot.This fixes our issues in napari.