Skip to content

Add Tact lexer#2571

Closed
aSpite wants to merge 5 commits intopygments:masterfrom
aSpite:master
Closed

Add Tact lexer#2571
aSpite wants to merge 5 commits intopygments:masterfrom
aSpite:master

Conversation

@aSpite
Copy link

@aSpite aSpite commented Nov 6, 2023

Tact is a new programming language for the TON blockchain that is focused on efficiency and simplicity. Pygments already has lexers for fift, func, which are also languages for writing smart contracts in the TON blockchain.

More:

jeanas
jeanas requested changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@jeanas jeanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick comments because I don't have the time to review this fully right now.

@aSpite aSpite requested a review from jeanas November 8, 2023 09:46
@aSpite
Copy link
Author

aSpite commented Nov 11, 2023

@jeanas, can you check again?

@jeanas
Copy link
Contributor

jeanas commented Nov 11, 2023

There are many PRs on this repo. We do our best to review them in reasonable delays, but please allow some time.

jeanas
jeanas requested changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@jeanas jeanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to contribute.

This is a bit hard to review right now due to the many states; I think it will be much simpler after flattening it a bit.

@aSpite aSpite requested a review from jeanas November 16, 2023 06:16
@jeanas
Copy link
Contributor

jeanas commented Nov 21, 2023

Thanks for the updates. There were regex linting failures in the CI, and I can't push the fixes to your PR branch because you opened the PR from the master branch of your fork, so I've pushed the combined changes to master directly as commit b23b4d8.

@jeanas jeanas closed this Nov 21, 2023
jeanas added a commit that referenced this pull request Nov 21, 2023
@jeanas
Add Tact lexer (#2571)
b23b4d8
@aSpite aSpite mentioned this pull request Nov 22, 2023
Closed
@aSpite
Copy link
Author

aSpite commented Nov 22, 2023

Thanks for the review and help in improving the lexer.

@Anteru Anteru added the A-lexing area: changes to individual lexers label Apr 28, 2024
@Anteru Anteru added this to the 2.18.0 milestone Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeanas jeanas Awaiting requested review from jeanas

Assignees

No one assigned

Labels

A-lexing area: changes to individual lexers

Projects

None yet

Milestone

2.18.0

Development

Successfully merging this pull request may close these issues.

3 participants

@aSpite @jeanas @Anteru