Merged
Conversation
Contributor
|
(Another potential pygments contributor here...) |
Contributor
Well, we (maintainers) update it ourselves; we don't ask contributors to do this. (But thank you for taking a look at the PR.) |
jeanas
reviewed
Jan 13, 2024
jeanas
reviewed
Jan 13, 2024
Co-authored-by: Jean Abou-Samra <[email protected]>
jeanas
reviewed
Jan 13, 2024
jeanas
reviewed
Jan 13, 2024
jeanas
reviewed
Jan 13, 2024
Contributor
jeanas
left a comment
jeanas
left a comment
There was a problem hiding this comment.
Looks OK. Since it seems this language can contain embedded C, shouldn't 'types' and 'keywords' have an inherit at the end to also highlight C types/keywords?
Contributor
Author
|
Promela does not have all the types and keywords of C. Only the ones I specified, so |
jeanas
reviewed
Jan 14, 2024
jeanas
reviewed
Jan 14, 2024
Contributor
|
Sorry for the delay. Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a lexer for Promela. (https://spinroot.com/spin/whatispin.html)
Promela (Process Meta Language) is a C-like language used by SPIN to formally model software and hardware systems. SPIN (Simple Promela Interpreter) was originally developed in the 1980s at Bell Labs and since 1991 has been open-source and is a popular formal methods tool.
Pygments already supports other popular formal methods languages, including Isabelle, Coq, and NuSmv. Promela would be a fitting addition.
I have not included test snippets since PromelaLexer is derived from CLexer, though I have tested that it produces correct highlighting on a few of my own Promela files.Edit: I added snippets and examplefiles and rantox -e checkandtox -e mapfileswhich both succeeded.