Merged
Conversation
This is a direct translation from the work done by @kaushalmodi in GoChroma, as per this comment: pygments#426 (comment) Includes improvements done to the Chroma lexer at a later date.
Contributor
|
Hi @jeanas, is there anything I could do to help move this forward? |
Contributor
Author
|
I just need to find a bit of time to finish cleaning up. Probably this week-end. |
Contributor
Author
|
@goshatch Sorry for the long delay, exams and all that. I did a good number of changes everywhere, fixing some bugs (e.g., some regexes were matching over-eagerly), and improving some token types, please check the new lexer and let me know if you find anything strange, otherwise I'll merge it. Thanks! |
Contributor
|
@jeanas Thank you very much! I appreciate your hard work. I've tried it locally and everything looks good to me, so I'm happy for this to be merged. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@goshatch Redux of #2628