GH-110793: add GitHub Actions job that runs tests after installing#110794
GH-110793: add GitHub Actions job that runs tests after installing#110794FFY00 wants to merge 6 commits intopython:mainfrom
Conversation
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
|
The job is now successful, this is ready for review. I'd still wait a little bit before merging, to see if there is any discussion on the issue. |
Signed-off-by: Filipe Laíns <[email protected]>
| --with-openssl-rpath | ||
| - name: Build CPython out-of-tree | ||
| working-directory: ${{ env.CPYTHON_BUILDDIR }} | ||
| run: make -j4 |
There was a problem hiding this comment.
I think that's the number of threads for Linux and Windows.
In this PR, I just copied the other jobs, so this comes from there. We can do the improvements you are suggesting (would also be nicer when running locally with act for eg), but it should probably be in a different PR.
|
If we go for this, let's do them as reusable workflows: Examples:
Possibly also |
I noticed Let's try adding them to the new job.
Agreed. Do you want to implement that in this PR or in a followup one? |
|
It would be good in this PR. |



Uh oh!
There was an error while loading. Please reload this page.