gh-113086: Add tests for os.chmod() and os.lchmod() by serhiy-storchaka · Pull Request #113087 · python/cpython

serhiy-storchaka · 2023-12-14T06:49:51Z

Also make test_copymode_symlink_to_symlink in test_shutil more strict.

Issue: Add tests for os.chmod() and os.lchmod() #113086

Also make test_copymode_symlink_to_symlink in test_shutil more strict.

miss-islington-app · 2023-12-14T07:16:09Z

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

bedevere-app · 2023-12-14T07:16:24Z

GH-113088 is a backport of this pull request to the 3.12 branch.

bedevere-app · 2023-12-14T07:16:30Z

GH-113089 is a backport of this pull request to the 3.11 branch.

…13087) Also make test_copymode_symlink_to_symlink in test_shutil more strict. (cherry picked from commit b4f2c89) Co-authored-by: Serhiy Storchaka <[email protected]>

GH-113088) Also make test_copymode_symlink_to_symlink in test_shutil more strict. (cherry picked from commit b4f2c89) Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-bot · 2023-12-14T07:32:27Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot wasm32-wasi 3.x has failed when building commit b4f2c89.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1046/builds/3741) and take a look at the build logs.
Check if the failure is related to this commit (b4f2c89) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1046/builds/3741

Failed tests:

test_posix

Failed subtests:

test_chmod_file - test.test_posix.PosixTester.test_chmod_file
test_chmod_dir - test.test_posix.PosixTester.test_chmod_dir

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Lib/test/test_posix.py", line 970, in test_chmod_dir
    self.check_chmod(posix.chmod, target)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
  File "/Lib/test/test_posix.py", line 952, in check_chmod
    self.assertEqual(os.stat(target).st_mode, new_mode)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 16384 != 16530


Traceback (most recent call last):
  File "/Lib/test/test_posix.py", line 960, in test_chmod_file
    self.check_chmod(posix.chmod, os_helper.TESTFN)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Lib/test/test_posix.py", line 952, in check_chmod
    self.assertEqual(os.stat(target).st_mode, new_mode)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 32768 != 32914

GH-113089) Also make test_copymode_symlink_to_symlink in test_shutil more strict. (cherry picked from commit b4f2c89) Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-bot · 2023-12-14T07:45:24Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot wasm32-wasi 3.11 has failed when building commit e4cdb74.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1047/builds/1156) and take a look at the build logs.
Check if the failure is related to this commit (e4cdb74) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1047/builds/1156

Failed tests:

test_posix

Failed subtests:

test_chmod_file - test.test_posix.PosixTester.test_chmod_file
test_chmod_dir - test.test_posix.PosixTester.test_chmod_dir

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Lib/test/test_posix.py", line 960, in test_chmod_file
    self.check_chmod(posix.chmod, os_helper.TESTFN)
  File "/Lib/test/test_posix.py", line 952, in check_chmod
    self.assertEqual(os.stat(target).st_mode, new_mode)
AssertionError: 32768 != 32914


Traceback (most recent call last):
  File "/Lib/test/test_posix.py", line 970, in test_chmod_dir
    self.check_chmod(posix.chmod, target)
  File "/Lib/test/test_posix.py", line 952, in check_chmod
    self.assertEqual(os.stat(target).st_mode, new_mode)
AssertionError: 16384 != 16530

bedevere-bot · 2023-12-14T07:47:20Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot wasm32-wasi 3.12 has failed when building commit 0bd1899.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1124/builds/532) and take a look at the build logs.
Check if the failure is related to this commit (0bd1899) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1124/builds/532

Failed tests:

test_posix

Failed subtests:

test_chmod_file - test.test_posix.PosixTester.test_chmod_file
test_chmod_dir - test.test_posix.PosixTester.test_chmod_dir

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Lib/test/test_posix.py", line 960, in test_chmod_file
    self.check_chmod(posix.chmod, os_helper.TESTFN)
  File "/Lib/test/test_posix.py", line 952, in check_chmod
    self.assertEqual(os.stat(target).st_mode, new_mode)
AssertionError: 32768 != 32914


Traceback (most recent call last):
  File "/Lib/test/test_posix.py", line 970, in test_chmod_dir
    self.check_chmod(posix.chmod, target)
  File "/Lib/test/test_posix.py", line 952, in check_chmod
    self.assertEqual(os.stat(target).st_mode, new_mode)
AssertionError: 16384 != 16530

…13087) Also make test_copymode_symlink_to_symlink in test_shutil more strict.

pythongh-113086: Add tests for os.chmod() and os.lchmod()

9ee5c7b

Also make test_copymode_symlink_to_symlink in test_shutil more strict.

serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Dec 14, 2023

bedevere-app bot added the awaiting core review label Dec 14, 2023

bedevere-app bot mentioned this pull request Dec 14, 2023

Add tests for os.chmod() and os.lchmod() #113086

Closed

serhiy-storchaka merged commit b4f2c89 into python:main Dec 14, 2023

bedevere-app bot removed the awaiting core review label Dec 14, 2023

serhiy-storchaka deleted the test-chmod branch December 14, 2023 07:16

bedevere-app bot removed the needs backport to 3.12 only security fixes label Dec 14, 2023

bedevere-app bot removed the needs backport to 3.11 only security fixes label Dec 14, 2023

corona10 pushed a commit to corona10/cpython that referenced this pull request Dec 15, 2023

pythongh-113086: Add tests for os.chmod() and os.lchmod() (pythonGH-1…

59bcb6c

…13087) Also make test_copymode_symlink_to_symlink in test_shutil more strict.

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024

pythongh-113086: Add tests for os.chmod() and os.lchmod() (pythonGH-1…

2224761

…13087) Also make test_copymode_symlink_to_symlink in test_shutil more strict.

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024

pythongh-113086: Add tests for os.chmod() and os.lchmod() (pythonGH-1…

822db63

…13087) Also make test_copymode_symlink_to_symlink in test_shutil more strict.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

gh-113086: Add tests for os.chmod() and os.lchmod()#113087

gh-113086: Add tests for os.chmod() and os.lchmod()#113087
serhiy-storchaka merged 1 commit intopython:mainfrom
serhiy-storchaka:test-chmod

serhiy-storchaka commented Dec 14, 2023 •

edited by bedevere-app bot

Loading

Uh oh!

miss-islington-app bot commented Dec 14, 2023

Uh oh!

bedevere-app bot commented Dec 14, 2023

Uh oh!

bedevere-app bot commented Dec 14, 2023

Uh oh!

bedevere-bot commented Dec 14, 2023

Uh oh!

bedevere-bot commented Dec 14, 2023

Uh oh!

bedevere-bot commented Dec 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

serhiy-storchaka commented Dec 14, 2023 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miss-islington-app bot commented Dec 14, 2023

Uh oh!

bedevere-app bot commented Dec 14, 2023

Uh oh!

bedevere-app bot commented Dec 14, 2023

Uh oh!

bedevere-bot commented Dec 14, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Dec 14, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Dec 14, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

serhiy-storchaka commented Dec 14, 2023 •

edited by bedevere-app bot

Loading