gh-136535: Tests: Correct `Py_TPFLAGS_MANAGED_DICT` in `test_class.py` by ever0de · Pull Request #136538 · python/cpython

ever0de · 2025-07-11T11:31:10Z

The Py_TPFLAGS_MANAGED_DICT constant in Lib/test/test_class.py was incorrectly set to (1 << 2) instead of the correct (1 << 4) from object.h.

issue: #136535

Issue: Incorrect value for Py_TPFLAGS_MANAGED_DICT in Lib/test/test_class.py #136535

python-cla-bot · 2025-07-11T11:31:15Z

All commit authors signed the Contributor License Agreement.

bedevere-app · 2025-07-11T11:31:17Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

…ass.py` The `Py_TPFLAGS_MANAGED_DICT` constant in `Lib/test/test_class.py` was incorrectly set to (1 << 2) instead of the correct (1 << 4) from object.h.

corona10

LGTM, I also double checked with the original reference:

cpython/Include/object.h

Line 551 in 47b01da

#define Py_TPFLAGS_MANAGED_DICT (1 << 4)

I am waiting @Fidget-Spinner or @markshannon 's review also.

corona10

Hi would you like to improve the test if the is Py_TPFLAGS_MANAGED_DICT wrongly set?

With my local change it is passed if I modify the value into 1 << 2, I prefer to prevent regression in the future.

bedevere-app · 2025-07-13T02:30:51Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

ever0de · 2025-07-13T02:45:33Z

Hi would you like to improve the test if the is Py_TPFLAGS_MANAGED_DICT wrongly set?

With my local change it is passed if I modify the value into 1 << 2, I prefer to prevent regression in the future.

Hello. I thought the test I added would prevent regression issues, but it didn't.
I think I can prevent this problem by checking Py_TPFLAGS_INLINE_VALUES (1 << 2 flag) in NoManagedDict. Would it be better to add it this way?
If you have any other better improvement suggestions, could you please propose them? Thank you!

Lib/test/test_class.py

corona10 · 2025-07-13T05:03:15Z

Lib/test/test_class.py


 class TestInlineValues(unittest.TestCase):

-    def test_flags(self):


Please revive test_flags also.

@ever0de Oh it was my miss, you don't have to revive :(

Ah, I see, Should I drop this commit then?

Yeah, please revert b39ca1a

corona10

lgtm!

corona10 · 2025-07-13T05:04:36Z

Lib/test/test_class.py

        self.c = 3
        self.d = 4

+class VarSizedSubclass(tuple):


Suggested change

class VarSizedSubclass(tuple):

class VarSizedSubclass(tuple):

corona10 · 2025-07-13T05:04:52Z

Lib/test/test_class.py

+Py_TPFLAGS_MANAGED_DICT = (1 << 4)
+
+class NoManagedDict:
+    __slots__ = ('a',)


Suggested change

__slots__ = ('a',)

__slots__ = ('a',)

pep 8

https://peps.python.org/pep-0008/#blank-lines

This reverts commit b39ca1a.

ever0de · 2025-08-11T09:07:50Z

Is there any feedback or are there any requested changes I should be aware of?

Fidget-Spinner · 2025-08-11T12:05:52Z

I completely forgot how the managed dict works as it's been a few years, so I don't think I can review this. Sorry!

miss-islington-app · 2025-10-24T11:20:14Z

Thanks @ever0de for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

…ass.py` (pythongh-136538) (cherry picked from commit aa4b5a7) Co-authored-by: Jiseok CHOI <[email protected]>

bedevere-app · 2025-10-24T11:20:28Z

GH-140532 is a backport of this pull request to the 3.14 branch.

bedevere-app · 2025-10-24T11:20:34Z

GH-140533 is a backport of this pull request to the 3.13 branch.

…lass.py` (gh-136538) (gh-140533)

…lass.py` (gh-136538) (gh-140532)

bedevere-bot · 2025-10-24T13:43:51Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows11 Bigmem 3.14 (tier-1) has failed when building commit 08f6b3f.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1799/builds/435) and take a look at the build logs.
Check if the failure is related to this commit (08f6b3f) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1799/builds/435

Failed tests:

test_os

Failed subtests:

test_listmounts - test.test_os.Win32ListdriveTests.test_listmounts

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "R:\buildarea\3.14.ambv-bb-win11.bigmem\build\Lib\test\test_os.py", line 3014, in test_listmounts
    self.assertSetEqual(
    ~~~~~~~~~~~~~~~~~~~^
        set(mounts),
        ^^^^^^^^^^^^
        self.known_mounts & set(mounts),
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
AssertionError: Items in the first set but not the second:
'R:\\'

…ass.py` (pythongh-136538)

bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Jul 11, 2025

bedevere-app bot mentioned this pull request Jul 11, 2025

Incorrect value for Py_TPFLAGS_MANAGED_DICT in Lib/test/test_class.py #136535

Closed

StanFromIreland added the skip news label Jul 11, 2025

ever0de force-pushed the fix-issue-136535 branch from 665ca05 to 6050223 Compare July 11, 2025 14:22

pythongh-136535: Tests: Correct Py_TPFLAGS_MANAGED_DICT in `test_cl…

407de3c

…ass.py` The `Py_TPFLAGS_MANAGED_DICT` constant in `Lib/test/test_class.py` was incorrectly set to (1 << 2) instead of the correct (1 << 4) from object.h.

ever0de force-pushed the fix-issue-136535 branch from 30edb78 to 407de3c Compare July 12, 2025 11:54

corona10 requested review from Fidget-Spinner and markshannon July 13, 2025 02:24

corona10 approved these changes Jul 13, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels Jul 13, 2025

corona10 requested changes Jul 13, 2025

View reviewed changes

bedevere-app bot removed the awaiting merge label Jul 13, 2025

bedevere-app bot added the awaiting changes label Jul 13, 2025

corona10 added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 13, 2025

corona10 reviewed Jul 13, 2025

View reviewed changes

Lib/test/test_class.py Show resolved Hide resolved

Improve tests for type flags to prevent regressions

9cd9c5b

corona10 reviewed Jul 13, 2025

View reviewed changes

corona10 approved these changes Jul 13, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting changes labels Jul 13, 2025

corona10 reviewed Jul 13, 2025

View reviewed changes

revive test_flags

b39ca1a

ever0de added 2 commits July 13, 2025 14:06

PEP 8

fd8e8e6

Revert "revive test_flags"

63aff56

This reverts commit b39ca1a.

corona10 merged commit aa4b5a7 into python:main Oct 24, 2025
40 checks passed

bedevere-app bot removed the awaiting merge label Oct 24, 2025

bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 24, 2025

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 24, 2025

corona10 pushed a commit that referenced this pull request Oct 24, 2025

[3.13] gh-136535: Tests: Correct Py_TPFLAGS_MANAGED_DICT in `test_c…

166b354

…lass.py` (gh-136538) (gh-140533)

corona10 pushed a commit that referenced this pull request Oct 24, 2025

[3.14] gh-136535: Tests: Correct Py_TPFLAGS_MANAGED_DICT in `test_c…

08f6b3f

…lass.py` (gh-136538) (gh-140532)

StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025

pythongh-136535: Tests: Correct Py_TPFLAGS_MANAGED_DICT in `test_cl…

b239018

…ass.py` (pythongh-136538)


		class TestInlineValues(unittest.TestCase):

		def test_flags(self):

	class VarSizedSubclass(tuple):

	class VarSizedSubclass(tuple):

Uh oh!

Conversation

ever0de commented Jul 11, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

python-cla-bot bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-app bot commented Jul 11, 2025

Uh oh!

corona10 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

corona10 left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-app bot commented Jul 13, 2025

Uh oh!

ever0de commented Jul 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

corona10 Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

corona10 Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

ever0de Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

corona10 Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

corona10 left a comment

Choose a reason for hiding this comment

Uh oh!

corona10 Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

corona10 Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

corona10 Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

ever0de commented Aug 11, 2025

Uh oh!

Fidget-Spinner commented Aug 11, 2025

Uh oh!

Uh oh!

miss-islington-app bot commented Oct 24, 2025

Uh oh!

bedevere-app bot commented Oct 24, 2025

Uh oh!

bedevere-app bot commented Oct 24, 2025

Uh oh!

bedevere-bot commented Oct 24, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ever0de commented Jul 11, 2025 •

edited by bedevere-app bot

Loading

python-cla-bot bot commented Jul 11, 2025 •

edited

Loading

corona10 left a comment •

edited

Loading

ever0de commented Jul 13, 2025 •

edited

Loading