bpo-34397: Remove redundant overflow checks in list and tuple implementation.#8757
Merged
miss-islington merged 1 commit intopython:masterfrom May 25, 2020
Merged
Conversation
jdemeyer
requested changes
Aug 5, 2019
Contributor
jdemeyer
left a comment
jdemeyer
left a comment
There was a problem hiding this comment.
I agree with the comments of Tim Peters on https://bugs.python.org/issue34397: the assertions should check what is actually required.
sir-sigurd
force-pushed
the
list-tuple-overlow-checks
branch
from
b96b7db to
4b5bbd8
Compare
Contributor
Author
|
I reworked assertions as requested. |
Contributor
Author
|
@tim-one |
Contributor
|
Merging based on @tim-one's approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34397
Automerge-Triggered-By: @csabella