Fix crash on match statement with value restricted TypeVar#13728
Merged
hauntsaninja merged 4 commits intopython:masterfrom Sep 26, 2022
Merged
Fix crash on match statement with value restricted TypeVar#13728hauntsaninja merged 4 commits intopython:masterfrom
hauntsaninja merged 4 commits intopython:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
JelleZijlstra
approved these changes
Sep 25, 2022
| guards=self.optional_expressions(o.guards), | ||
| bodies=self.blocks(o.bodies), | ||
| ) | ||
|
|
Member
There was a problem hiding this comment.
I wonder why the next method does not do self.expr(node.expr).
Collaborator
Author
There was a problem hiding this comment.
Yeah, I was wondering about that too. I guess I should probably not be lazy and write out all the boilerplate for patterns...
This comment has been minimized.
This comment has been minimized.
1 similar comment
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
hauntsaninja
changed the title
sobolevn
approved these changes
Sep 26, 2022
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Sadly, I cannot come up with any ideas on how to catch this early.
Since NodeVisitor does not have abstract methods.
🤔
dosisod
added a commit
to dosisod/refurb
that referenced
this pull request
Sep 27, 2022
Sadly, python/mypy#13728 was not merged into the 0.981 release, meaning we still have the weird None check when using the `extract_binary_oper` function. I could just use the master branch instead of the pypi release of mypy, but those don't have wheels built for it, meaning it would (probably) be a lot harder to install for the end user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13727, fixes #12448, fixes #13213