Set soft error limit default to -1 (unlimited)#15138
Merged
hauntsaninja merged 2 commits intopython:masterfrom Apr 26, 2023
Merged
Set soft error limit default to -1 (unlimited)#15138hauntsaninja merged 2 commits intopython:masterfrom
hauntsaninja merged 2 commits intopython:masterfrom
Conversation
rohitsanj
changed the title
hauntsaninja
approved these changes
Apr 25, 2023
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Thanks for fixing!
This comment has been minimized.
This comment has been minimized.
ikonst
reviewed
Apr 25, 2023
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
2 tasks
hauntsaninja
pushed a commit
that referenced
this pull request
Nov 23, 2023
Default value of `MANY_ERRORS_THRESHOLD` was set to `-1` in #15138, which is also the default value of the `--soft-error-limit` CLI option. However the CLI docs were not updated accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14915
When there are more than 200 errors to report, mypy "softly" trims the output without notifying the user that it did so. We want to currently disable this by setting the
--soft-error-limitdefault to-1which would list out all the errors.