Fix xml writing bug introduced in #16388#16713
Merged
JelleZijlstra merged 1 commit intopython:masterfrom Jan 2, 2024
frobian21:junit-fix
Merged
Fix xml writing bug introduced in #16388#16713JelleZijlstra merged 1 commit intopython:masterfrom frobian21:junit-fix
JelleZijlstra merged 1 commit intopython:masterfrom
frobian21:junit-fix
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JelleZijlstra
approved these changes
Jan 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#16388 introduced a bug where invalid xml could be produced by
write_junit_xml, as special characters were no longer being escaped.The fix is to revert the removal of
from xml.sax.saxutils import escapeandescape("\n".join(messages))in thewrite_junit_xmlfunction.I've added a small test case which checks that the
<,>,&are escaped correctly in the xml.