[mypyc] Support ellipsis (...) expressions in class bodies#17923
Merged
JukkaL merged 3 commits intopython:masterfrom Oct 14, 2024
Newbytee:ellipsis-class
Merged
[mypyc] Support ellipsis (...) expressions in class bodies#17923JukkaL merged 3 commits intopython:masterfrom Newbytee:ellipsis-class
JukkaL merged 3 commits intopython:masterfrom
Newbytee:ellipsis-class
Conversation
JukkaL
reviewed
Oct 11, 2024
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Thanks for the PR! Some minor things, looks good overall.
This can be used to declare concise custom exceptions, e.g.
class UnknownReleaseError(ValueError): ...
which otherwise probably would be written
class UnknownReleaseError(ValueError):
pass
and is supported by CPython.
Closes mypyc/mypyc#1069
for more information, see https://pre-commit.ci
JukkaL
approved these changes
Oct 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be used to declare concise custom exceptions, e.g.
which otherwise probably would be written
and is supported by CPython.
Closes mypyc/mypyc#1069