[mypyc] Optimize dunder methods#17934
Merged
JukkaL merged 1 commit intopython:masterfrom Oct 18, 2024
Merged
Conversation
e1da693 to
34eb9c1
Compare
Contributor
Author
|
Hi @JukkaL , can you review this change? |
Collaborator
|
I'll try to get to this later this week. This week is pretty busy, since mypy 1.12 release just got out and a bunch of regressions have been reported. |
2379a28 to
a73b113
Compare
JukkaL
approved these changes
Oct 18, 2024
Collaborator
JukkaL
left a comment
There was a problem hiding this comment.
This looks good, thanks.
I don't want to keep the strict_dunder_typing flag around for long. Maybe it would only be enabled for value types, or we can require always explicitly annotating NotImplemented in return types.
We should have a minimal number of mode flags that impact compilation. This can be sorted out in the future, however.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change gives mypyc the ability to optionally optimize dunder methods that can guarantee strict adherence to its signature typing. The optimization allows to bypass vtable for dunder methods in certain cases that are applicable.
Currently, mypy has adopted the convention of accept dunder methods that return
NotImplementedvalue even when its signature do not reflect this possibility. With this change and by enabling an special flag, mypyc will expect strict typing be honored and will unleash more optimizations like native call without vtable lookup for some cases on dunder method calls.For example it could avoid calls to RichCompare Python API making the code can be fully optimized in by the C compiler when some comparison with dunders are required.
Example:
would produce:
Instead of:
Default behavior is kept.
Tests run with both of strict typing enabled and disabled.
Should be rebased and reviewed after #17886