Skip to content

[mypyc] Fix wheel build for cp313-win#17941

Merged
JukkaL merged 1 commit intopython:masterfrom
cdce8p:fix-win-wheels
Oct 14, 2024
Merged

[mypyc] Fix wheel build for cp313-win#17941
JukkaL merged 1 commit intopython:masterfrom
cdce8p:fix-win-wheels

Conversation

@cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Oct 14, 2024

#17929 seems to have broken the wheel builder but only on Windows with Python 3.13.

  C:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\nuget-cpython\python.3.13.0\tools\include\internal\pycore_unicodeobject.h(262): error C2375: '_PyUnicode_Equal': redefinition; different linkage
  D:\a\mypy_mypyc-wheels\mypy_mypyc-wheels\mypy\mypyc\lib-rt\pythoncapi_compat.h(1540): note: see declaration of '_PyUnicode_Equal'

  C:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\nuget-cpython\python.3.13.0\tools\include\internal\pycore_pyhash.h(24): error C2375: '_Py_HashBytes': redefinition; different linkage
  D:\a\mypy_mypyc-wheels\mypy_mypyc-wheels\mypy\mypyc\lib-rt\pythoncapi_compat.h(1567): note: see declaration of '_Py_HashBytes'

https://github.com/mypyc/mypy_mypyc-wheels/actions/runs/11327195039/job/31497783023#step:4:3766

MSVC seems to require that the signature matches the upstream one exactly.

@cdce8p cdce8p changed the title Fix wheel build for cp313-win [mypyc] Fix wheel build for cp313-win Oct 14, 2024
@cdce8p cdce8p added the topic-mypyc mypyc bugs label Oct 14, 2024
@cdce8p cdce8p mentioned this pull request Oct 14, 2024
Merged
JukkaL
JukkaL approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@JukkaL JukkaL merged commit fc75ca7 into python:master Oct 14, 2024
@cdce8p cdce8p deleted the fix-win-wheels branch October 14, 2024 15:41
@cdce8p cdce8p mentioned this pull request Oct 14, 2024
Merged
@cdce8p
Copy link
Collaborator Author

cdce8p commented Oct 14, 2024

Opened python/pythoncapi-compat#115 to fix it upstream as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees

No one assigned

Labels

topic-mypyc mypyc bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cdce8p @JukkaL