[mypyc] fix relative imports in __init__.py#17979
Merged
JukkaL merged 1 commit intopython:masterfrom Oct 21, 2024
Merged
Conversation
JukkaL
approved these changes
Oct 17, 2024
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Thanks! It would be good to add a test, if it's easy enough to do it.
Collaborator
Author
|
It looks like the existing test testMultiModuleRelative (added in mypyc/mypyc#625) isn't even actually compiled? So will need some test infra changes... |
Collaborator
|
Ok, in that case let's merge this as is. |
HorlogeSkynet
added a commit
to HorlogeSkynet/SSHubl
that referenced
this pull request
Dec 23, 2024
> (maybe) related to python/mypy#17979
HorlogeSkynet
added a commit
to HorlogeSkynet/SSHubl
that referenced
this pull request
Dec 23, 2024
> (maybe) related to python/mypy#17979
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mypyc/mypyc#1070
Missed in #10543