Fix crash when checking slice expression with step 0 in tuple index#18063
Merged
hauntsaninja merged 1 commit intopython:masterfrom Oct 29, 2024
Merged
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Collaborator
Author
|
Python 3.8 failure on Windows looks like a flake. |
brianschubert
commented
Oct 28, 2024
Comment on lines
+1443
to
+1444
| # TODO: emit better error when 0 is used for step | ||
| ()[::0] # E: Ambiguous slice of a variadic tuple |
Collaborator
Author
There was a problem hiding this comment.
If #18065 gets merged, this test will change:
Suggested change
| # TODO: emit better error when 0 is used for step | |
| ()[::0] # E: Ambiguous slice of a variadic tuple | |
| ()[::0] # E: Slice step cannot be 0 |
hauntsaninja
approved these changes
Oct 29, 2024
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Thanks, makes sense to do the simplest fix for a crash first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18062
I plan to follow up with another PR that adds a better error messages for slice expressions with
step=0when indexing standard containers that disallow that.