Update for Windows platform. Resolves #18096#18097
Merged
hauntsaninja merged 1 commit intopython:masterfrom Nov 4, 2024
Merged
Update for Windows platform. Resolves #18096#18097hauntsaninja merged 1 commit intopython:masterfrom
hauntsaninja merged 1 commit intopython:masterfrom
Conversation
sobolevn
reviewed
Nov 3, 2024
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Is this specific to your setup? I haven't heard about python3 being a problem on Windows before.
hauntsaninja
approved these changes
Nov 3, 2024
AlexWaygood
approved these changes
Nov 4, 2024
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
I was a Windows programmer for several years -- I can confirm that most Python installations on Windows typically come with a python.exe executable but not a python3.exe executable
Member
|
The flip side is that on my Mac: But maybe we can just expect contributors to figure that out. |
hauntsaninja
approved these changes
Nov 4, 2024
Collaborator
|
The instructions still say this for non-Windows, so Mac should be fine: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18096
Update of CONTRIBUTING.md document to be able to run tests using Windows OS.
Change to:
Change to:
described above to install
toxviapip(e.g.,python3 -m pip install tox).Change to:
described above to install
toxviapip(e.g.,python -m pip install tox).