[mypyc] Optimize str.encode with specializations for common used encodings#18232
Merged
JukkaL merged 3 commits intopython:masterfrom Dec 3, 2024
Merged
[mypyc] Optimize str.encode with specializations for common used encodings#18232JukkaL merged 3 commits intopython:masterfrom
JukkaL merged 3 commits intopython:masterfrom
Conversation
JukkaL
reviewed
Dec 3, 2024
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
I think some cases aren't covered by the logic. Suggested some test cases that should help.
| s.encode('utf-8', errors='strict') | ||
| s.encode('utf-8', 'backslashreplace') | ||
| s.encode(encoding='ascii') | ||
| s.encode('ascii', 'backslashreplace') |
Collaborator
There was a problem hiding this comment.
Also test cases where the specialization shouldn't be applied. Examples: s.encode(x), s.encode('a', x), s.encode('utf8', errors=x) and s.encode(errors=x) where x is not a literal.
Test cases where we have two keyword args: s.encode(encoding=..., errors=...) and s.encode(errors=..., encoding=...).
Collaborator
Author
There was a problem hiding this comment.
I've updated the logic to work out the args better and added more tests. Please take another look!
svalentin
force-pushed
the
mypyc-str-encode
branch
from
764d8d0 to
61cd522
Compare
for more information, see https://pre-commit.ci
JukkaL
added a commit
that referenced
this pull request
Aug 19, 2025
This is similar to #18232, which specialized `encode`. A micro-benchmark that calls `decode` repeatedly was up to 45% faster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with:
With PR applied and running mypyc,
python3 -c "import test"runs in:0.5383486747741699
0.5224344730377197
0.555696964263916
Without PR applied:
0.7315819263458252
0.7105758190155029
0.7471706867218018
Similar times observed for "ascii"