[mypyc] Getting capsule pointer from module instead of PyCapsule_Import.#18286
Merged
JukkaL merged 2 commits intopython:masterfrom Dec 19, 2024
Merged
[mypyc] Getting capsule pointer from module instead of PyCapsule_Import.#18286JukkaL merged 2 commits intopython:masterfrom
JukkaL merged 2 commits intopython:masterfrom
Conversation
Contributor
Author
|
@hauntsaninja , @JukkaL : Can you please take a look at this pull request? I think it fixes an import bug that has been reported by many users. |
JukkaL
reviewed
Dec 19, 2024
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Thanks for fixing the issue! Looks good overall, just one error check seems to be missing.
| {{ | ||
| PyObject *tmp; | ||
| if (!(tmp = PyImport_ImportModule("{libname}"))) return NULL; | ||
| PyObject *capsule = PyObject_GetAttrString(tmp, "init_{full_modname}"); |
Collaborator
There was a problem hiding this comment.
Check for null return. Otherwise we may decref a null pointer below.
Contributor
Author
There was a problem hiding this comment.
Fixed it. Thanks.
JukkaL
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mypyc/mypyc#999.
PyCapsule_Importwas failing in sub-packages. Since the capsule is an attribute of the module, we can access the capsule from the module instead of importing it.