fix: fail check if not enough or too many types provided to `TypeAlia…#18308
Merged
JelleZijlstra merged 2 commits intopython:masterfrom Dec 19, 2024
Merged
fix: fail check if not enough or too many types provided to `TypeAlia…#18308JelleZijlstra merged 2 commits intopython:masterfrom
JelleZijlstra merged 2 commits intopython:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Member
JelleZijlstra
left a comment
There was a problem hiding this comment.
Thanks, could you add a test that exercises this code path?
To find the place to add a test, grep for TypeAliasType among the .test files.
bzoracler
commented
Dec 19, 2024
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JelleZijlstra
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…sType()`
Fixes #18307 by failing a type alias call check if the number of positional arguments isn't exactly 2 (one for the type name as a literal string, one for the target type to alias).
Before:
After:
The error messages above are propagated from a check with the
TypeAliasTypeconstructor definition from the stubs, so no further special-casing is necessary: