Fix line number for decorator issues#18392
Merged
hauntsaninja merged 1 commit intopython:masterfrom Dec 31, 2024
Merged
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: antidote (https://github.com/Finistere/antidote)
+ tests/core/test_inject.py:548: error: Unused "type: ignore" comment [unused-ignore]
+ tests/core/test_inject.py:549: error: Argument 1 to "method" of "Inject" has incompatible type "Callable[[], object]"; expected "Callable[[Any], object]" [arg-type]
|
A5rocks
approved these changes
Dec 31, 2024
Collaborator
A5rocks
left a comment
A5rocks
left a comment
There was a problem hiding this comment.
This makes sense. I assume the end line is at the actual def ... line?
Collaborator
Author
|
end line is the same, just matches end_lineno provided by the python ast |
hauntsaninja
added a commit
to hauntsaninja/mypy
that referenced
this pull request
Dec 31, 2024
Fixes python#17655 The decorator cleanup moves a type ignore, but so does the bug fix in python#18392 , so might as well batch into a single release
hauntsaninja
added a commit
that referenced
this pull request
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18391