Retain None (unreachable) when typemap is None with type(x) is Foo check#18486
Merged
hauntsaninja merged 2 commits intopython:masterfrom Jan 27, 2025
Merged
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
approved these changes
Jan 26, 2025
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Looks good! One nit that might be a little faster
Comment on lines
+5917
to
5921
| if all(m is None for m in list_maps): | ||
| return None | ||
| result_map = {} | ||
| for d in list_maps: | ||
| if d is not None: |
Collaborator
There was a problem hiding this comment.
Suggested change
| if all(m is None for m in list_maps): | |
| return None | |
| result_map = {} | |
| for d in list_maps: | |
| if d is not None: | |
| result_map = None | |
| for d in list_maps: | |
| if d is not None: | |
| if result_map is None: | |
| result_map = {} |
Collaborator
Author
There was a problem hiding this comment.
I'd keep my version if you don't mind: this part isn't hot (only reachable when we actually have some type(x) <op> Something checks), and I find it more explicit/slightly easier to follow. This shouldn't have any measurable performance impact.
x612skm
pushed a commit
to x612skm/mypy-dev
that referenced
this pull request
Feb 24, 2025
…check (python#18486) Fixes python#18428. Prevents rewriting `None` ("unreachable") typemaps as empty dicts ("nothing to infer")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18428.
Prevents rewriting
None("unreachable") typemaps as empty dicts ("nothing to infer")